Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: new(cmd,pkg): leverage falcoctl to skip generating configs for kernels where modern bpf is supported #43

Closed
wants to merge 1 commit into from

Conversation

FedeDP
Copy link
Collaborator

@FedeDP FedeDP commented Mar 21, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area cmd
/area pkg

What this PR does / why we need it:

Given our new roadmap: https://falco.org/docs/roadmap/, and the fact that for Falco 1.0.0 we are targeting to default to the modern bpf probe, i added an option to dbg-go to avoid generating configs for kernel where modern bpf is supported, disabling building of drivers for those kernels.
This behavior is disabled by default at the moment.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(cmd,pkg): leverage falcoctl to skip generating configs for kernels where modern bpf is supported

…s where modern bpf is supported.

This behavior is disabled by default at the moment.

Signed-off-by: Federico Di Pierro <[email protected]>
@poiana
Copy link

poiana commented Mar 21, 2024

@FedeDP: The label(s) kind/feature, area/cmd, area/pkg cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area cmd
/area pkg

What this PR does / why we need it:

Given our new roadmap: https://falco.org/docs/roadmap/, and the fact that for Falco 1.0.0 we are targeting to default to the modern bpf probe, i added an option to dbg-go to avoid generating configs for kernel where modern bpf is supported, disabling building of drivers for those kernels.
This behavior is disabled by default at the moment.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(cmd,pkg): leverage falcoctl to skip generating configs for kernels where modern bpf is supported

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link

poiana commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from leogr and maxgio92 March 21, 2024 08:41
@poiana
Copy link

poiana commented Mar 21, 2024

There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FedeDP
Copy link
Collaborator Author

FedeDP commented Mar 21, 2024

Wip because this requires falcosecurity/falcoctl#484.

github.com/aws/aws-sdk-go-v2/config v1.27.4
github.com/aws/aws-sdk-go-v2/credentials v1.17.4
github.com/aws/aws-sdk-go-v2/service/s3 v1.40.0
github.com/falcosecurity/driverkit v0.16.3
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump driverkit to v0.17.x on falcoctl too, before merging this!

@FedeDP
Copy link
Collaborator Author

FedeDP commented Mar 22, 2024

/close
This is wrong since modern-bpf Supported method directly checks against running kernel; therefore we cannot use the check for custom kernel releases.

@poiana poiana closed this Mar 22, 2024
@poiana
Copy link

poiana commented Mar 22, 2024

@FedeDP: Closed this PR.

In response to this:

/close
This is wrong since modern-bpf Supported method directly checks against running kernel; therefore we cannot use the check for custom kernel releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants